I apologize in advance for all the code, and how long the post is. I will make the code in Blue, so it stands out in the post.
Well, I just don't want to spend all day on this, so I'm hoping to find some help...again.
I want to output a message that only shows if a certain percentage of free space is low on a datastore (I have it at 15 percent). On my old script, I didn't create any objects, and for the datastore part I did this:
Function My-Data {
Function PercentFree { ## Start Function
param($ds)
[Math]::Round(($ds.FreeSpaceMB / $ds.CapacityMB * 100),0)
} ## End Function
$runOnce = 0
$datastores = Get-Datacenter 'Datacenter' | Get-Datastore
$vDataStore = @()
Foreach ($datastore in $datastores) {
if ($runOnce -eq 0) { Write ("`r" + "Please do not place any VMs on the following datastores today " + "(" + (Get-date -Format "MM-dd-yyyy") + ")" + "," + " they are low on space: (Never place VMs on the `"ISOs`" datastore)"); "`r"; $runOnce++ }
$vDataStore = "" | Select Datastore, UsedSpace, Capacity, PercentageFree
$vDataStore.Datastore = $datastore.Name
$vDatastore.UsedSpace = [Math]::Round($datastore.FreeSpaceGB)
$vDataStore.Capacity = [Math]::Round($datastore.CapacityGB)
$vDataStore.PercentageFree = PercentFree $datastore
#The IF that tells you that there is less that 15 percent of freespace on the datastores, and it outputs the information
if ($vDataStore.PercentageFree -lt 15 -and $vDataStore.Datastore -notmatch 'ISOs') { write $vDataStore.Datastore ("{0:N0}% free" -f $vDataStore.PercentageFree),`
("Total amount free = " + $vDataStore.UsedSpace + "GB"),("Total capacity = " + $vDataStore.Capacity + "GB")"`r" }
}
} #end Function My-Data
The above script is just a portion of the script, but would output the information below:
------------------------------------------------------------------------------------------------------
Please do not place any VMs on the following datastores today (05-15-2012), they are low on space:
Datastore-vdisk
13% free
Total amount free = 251GB
Total capacity = 1900GB
What I want is that same information, but now I want to dynamically add it to an existing object. The code below is the new script (just a portion)
Function My-Function {
$vDataStore = New-Object PSObject
$vDataStore | Add-Member -MemberType NoteProperty -Name "vCenter Datastores" -Value ($Alldatastore).count
$vDataStore | Add-Member -MemberType NoteProperty -Name "Total storage capacity of datastores" -Value ("$([Math]::Round((($Alldatastore | measure -Property CapacityGB -sum).sum) / 1024))" + "(TB)")
$vDataStore | Add-Member -MemberType NoteProperty -Name "Total amount of free space on datastores" -Value ("$([Math]::Round((($Alldatastore | measure -Property FreeSpaceGB -sum).sum) / 1024))" + "(TB)")
Write "Datastore information "`r" ",
$vDatastore | fl
} #end My-Function
What I think the solution is, is that after this:
if ($vDataStore.PercentageFree -lt 15 -and $vDataStore.Datastore -notmatch 'ISOs')
I basically copied a portion of the old script to the new script, I changed some of the names around, and tried this
Function My-Test {
Function PercentFree { ## Start Function
param($ds)
[Math]::Round(($ds.FreeSpaceMB / $ds.CapacityMB * 100),0)
} ## End Function
$Alldatastore = Get-Datacenter "Center" | Get-Datastore
$OBJvDataStore = New-Object PSObject
$OBJvDataStore | Add-Member -MemberType NoteProperty -Name "vCenter Datastores" -Value ($Alldatastore).count
$OBJvDataStore | Add-Member -MemberType NoteProperty -Name "Total storage capacity of datastores" -Value ("$([Math]::Round((($Alldatastore | measure -Property CapacityGB -sum).sum) / 1024))" + "(TB)")
$OBJvDataStore | Add-Member -MemberType NoteProperty -Name "Total amount of free space on datastores" -Value ("$([Math]::Round((($Alldatastore | measure -Property FreeSpaceGB -sum).sum) / 1024))" + "(TB)")
$runOnce = 0
Foreach ($datastore in $Alldatastore) {
if ($runOnce -eq 0) { Write ("`r" + "Please do not place any VMs on the following datastores today " + "(" + (Get-date -Format "MM-dd-yyyy") + ")" + "," + " they are low on space: (Never place VMs on the `"ISOs`" datastore)"); "`r"; $runOnce++ }
$vDataStore = "" | Select Datastore, UsedSpace, Capacity, PercentageFree
$vDataStore.Datastore = $datastore.Name
$vDatastore.UsedSpace = [Math]::Round($datastore.FreeSpaceGB)
$vDataStore.Capacity = [Math]::Round($datastore.CapacityGB)
$vDataStore.PercentageFree = PercentFree $datastore
#I tried various things here
if ($vDataStore.PercentageFree -lt 15 -and $vDataStore.Datastore -notmatch 'ISOs') {
$Hash = New-Object PSObject -Property @{
"Datastores with low space" = $vDataStore.Datastore("{0:N0}% free" -f $vDataStore.PercentageFree)
}
#I tried adding a member, but I could not get it to work
# Add-Member -InputObject $OBJvDataStore "Datastores with low space" -Value $vDataStore.Datastore ("{0:N0}% free" -f $vDataStore.PercentageFree),`
#("Total amount free = " + $vDataStore.UsedSpace + "GB"),
#("Total capacity = " + $vDataStore.Capacity + "GB") }
} # End Foreach
Write "Test",
$OBJvDataStore | fl
}
}
Thanks in advance, if I need to just upload or copy and paste the entire script, just let me know. I just didn't think it was needed, because I only have an issue with this one part.
