Accepted Solutions
Thanks for your time Guru.
When I execute the code $tasks is showing empty and its not able to view the object id ($tasklist.ObjectId) as $tasklist is empty.
But in vcenter i can able to see the error task.
When I do Get-Task parallelly I can see error and success tasks but its not collecting error tasks in $tasklist.
Below is the error
This is the complete script which I am trying to execute.Can you please re-correct.
Write-Host 'Fetching Resource Pools Info'
$allresourcepools = 'res1','res2'
$respExpression = "^$($allresourcepools -join '$|^')$"
foreach($resourcepool in (Get-View -ViewType ResourcePool -Filter @{'Name'=$respExpression})){
Write-Host "Fetching VMs in $resourcepool"
$vmsinresourcepool = Get-View -Id $resourcepool.Vm
$vmtoolsoutdate = $vmsinresourcepool|Where-Object {$_.guest.ToolsRunningStatus -eq 'guestToolsRunning' -and $_.guest.toolsversionstatus -eq 'guestToolsNeedUpgrade'}
$vmexpression= "^$($vmtoolsoutdate.name -join '$|^')$"
$vmtoolsupdate=Get-View -ViewType VirtualMachine -Filter @{'Name'=$vmexpression}
$msoutdate=Get-View -ViewType VirtualMachine -Filter @{'Name'=$vmexpression} |?{$_.Guest.GuestFullName -like '*Windows*'}
$otheros=Get-View -ViewType VirtualMachine -Filter @{'Name'=$vmexpression} |?{$_.Guest.GuestFullName -notlike '*Windows*'}
$installerArgs = '/S /v "/qn REBOOT=R ADDLOCAL=ALL REMOVE=Hgfs,WYSE"'
%{($msoutdate).UpgradeTools_Task($installerArgs)}
%{($otheros).UpgradeTools_Task($null)}
$tasks = @(Get-Task | where{$_.Name -eq 'UpgradeTools_Task' -and 'Running','Queued' -contains $_.State})
while ($tasks.Count -ne 0){
sleep 5
$tasks = @(Get-Task | where{$_.Name -eq 'UpgradeTools_Task' -and 'Running','Queued' -contains $_.State})
}
$tasklist = $tasks | Where-Object {$_.State -eq 'Error'}
$installfailedvms= Get-View -Id $tasklist.ObjectId -Property Name| Select-Object -ExpandProperty Name
$viewexpression= "^$($installfailedvms -join '$|^')$"
$allfailedvms=Get-View -ViewType VirtualMachine -Filter @{'Name'= $viewexpression} -Property Name,"Runtime.ToolsInstallerMounted" |?{$_.Runtime.ToolsInstallerMounted -ne 'true'} | %{$_.MountToolsInstaller()}
$msinstallfailed=Get-View -ViewType VirtualMachine -Filter @{'Name'=$viewexpression} |?{$_.Guest.GuestFullName -like '*Windows*'}
$installfailedotheros=Get-View -ViewType VirtualMachine -Filter @{'Name'=$viewexpression} |?{$_.Guest.GuestFullName -notlike '*Windows*'}
Write-Host Updating vmware tools on $msinstallfailed.name using invoke method
$scriptforwin = @'
if (!([Security.Principal.WindowsPrincipal][Security.Principal.WindowsIdentity]::GetCurrent()).IsInRole([Security.Principal.WindowsBuiltInRole] "Administrator")) { Start-Process powershell.exe "-NoProfile -ExecutionPolicy Bypass -File `"$PSCommandPath`"" -Verb RunAs; exit }
$driveletter=(Get-WmiObject win32_logicaldisk -filter 'DriveType=5').DeviceID
Start-Process -FilePath $driveletter\setup.exe -ArgumentList '-s -v-qn ADDLOCAL=ALL REBOOT=R'
'@
$found = $false
try{
$out1 = Invoke-VMScript -VM $msinstallfailed.name -GuestUser "administrator" -GuestPassword "admin@123" -ScriptText $scriptforwin -ScriptType Powershell -ErrorAction Stop | Select -ExpandProperty ScriptOutput
$found = $true
}
catch [VMware.VimAutomation.ViCore.Types.V1.ErrorHandling.InvalidGuestLogin]{
$out1 = "Invalid logon"
}
catch{
$out1 = "any other output"
}
if(!$found){
try{
$out2 = Invoke-VMScript -VM $msinstallfailed.name -GuestUser "administrator" -GuestPassword "admin@1234" -ScriptText $scriptforwin -ScriptType Powershell -ErrorAction Stop | Select -ExpandProperty ScriptOutput
$found = $true
}
catch [VMware.VimAutomation.ViCore.Types.V1.ErrorHandling.InvalidGuestLogin]{
$out2 = "Invalid logon"
}
catch{
$out2 = "any other output"
}
}
if(!$found){
try{
$out3 = Invoke-VMScript -VM $msinstallfailed.name -GuestUser "administrator" -GuestPassword "admin@1235" -ScriptText $scriptforwin -ScriptType Powershell -ErrorAction Stop | Select -ExpandProperty ScriptOutput
$found = $true
}
catch [VMware.VimAutomation.ViCore.Types.V1.ErrorHandling.InvalidGuestLogin]{
$out3 = "Invalid logon"
}
catch{
$out3 = "any other output"
}
}
Write-Output "VM: $($msinstallfailed.name): $found"
Write-Output "VM: $($msinstallfailed.name): $out1"
Write-Output "VM: $($msinstallfailed.name): $out2"
Write-Output "VM: $($msinstallfailed.name): $out3"
Write-Host Updating vmware tools on non-windows VMs $installfailedotheros.name using invoke method
$scriptfornonwindows = @'
mkdir -p /mnt/vmw-tools && mount /dev/cdrom /mnt/vmw-tools && VMW_TOOLS=$(ls /mnt/vmw-tools/ | grep .gz) && cp -f /mnt/vmw-tools/${VMW_TOOLS} /tmp/ && umount /mnt/vmw-tools && rmdir /mnt/vmw-tools && tar -zxvf /tmp/${VMW_TOOLS} -C /tmp/ && cd /tmp/vmware-tools-distrib/ && ./vmware-install.pl -d default && rm -rf vmware-tools-distrib/ && rm -f /tmp/${VMW_TOOLS} && cd ~
'@
$found = $false
try{
$out1 = Invoke-VMScript -VM $installfailedotheros.name -GuestUser "root" -GuestPassword "admin@123" -ScriptText $scriptfornonwindows -ScriptType Bash -ErrorAction Stop | Select -ExpandProperty ScriptOutput
$found = $true
}
catch [VMware.VimAutomation.ViCore.Types.V1.ErrorHandling.InvalidGuestLogin]{
$out1 = "Invalid logon"
}
catch{
$out1 = "any other output"
}
if(!$found){
try{
$out2 = Invoke-VMScript -VM $installfailedotheros.name -GuestUser "root" -GuestPassword "admin@1234" -ScriptText $scriptfornonwindows -ScriptType Bash -ErrorAction Stop | Select -ExpandProperty ScriptOutput
$found = $true
}
catch [VMware.VimAutomation.ViCore.Types.V1.ErrorHandling.InvalidGuestLogin]{
$out2 = "Invalid logon"
}
catch{
$out2 = "any other output"
}
}
if(!$found){
try{
$out3 = Invoke-VMScript -VM $installfailedotheros.name -GuestUser "root" -GuestPassword "admin@12345" -ScriptText $scriptfornonwindows -ScriptType Bash -ErrorAction Stop | Select -ExpandProperty ScriptOutput
$found = $true
}
catch [VMware.VimAutomation.ViCore.Types.V1.ErrorHandling.InvalidGuestLogin]{
$out3 = "Invalid logon"
}
catch{
$out3 = "any other output"
}
}
Write-Output "VM: $($installfailedotheros.name): $found"
Write-Output "VM: $($installfailedotheros.name): $out1"
Write-Output "VM: $($installfailedotheros.name): $out2"
Write-Output "VM: $($installfailedotheros.name): $out3"
}
Thanks Guru the script is working as expected
But while executing on multiple resources pools simultaneously I found that a logic I missed that the error tasks in vcenter which are still not cleared the script is again trying to mount the tools and running invoke cmd. So is there any way to fix it or should I wait until all the old tasks error tasks get cleared before running on other resource pools.