ufelmann
Contributor
Contributor

new Sigar().getProcArgs(pid) with limits

Hi I found out Sigar has difficulties with long arguments lines. e.g. java command line with long class path argument (I have 9115 chars)

Is this a known issue and can this be fixed.

Thanks,
Viktor
0 Kudos
4 Replies
ufelmann
Contributor
Contributor

I think this can be fixed, removing SIGAR_CMDLINE_MAX limitation
wmi.cpp
SIGAR_CMDLINE_MAX = 4096

Thanks,
Viktor
0 Kudos
dougm_hyperic
VMware Employee
VMware Employee

Hi Viktor,

I've opened and resolved this ticket: https://jira.hyperic.com/browse/SIGAR-230

You can get a binary that includes the fix here:
http://hudson.hyperic.com/job/sigar-1.6-x86-winnt/
http://hudson.hyperic.com/job/sigar-1.6-amd64-winnt/

Let us know if this works for you. Thanks.
0 Kudos
ufelmann
Contributor
Contributor

Hi Doug,

getting command lines up to 16KB works now. Thank you very much.

I wounder why you need limitations for command lines at all, if windows can handle lines e.g. 128KB than Sigar should also work for this line size.

Thanks
0 Kudos
sourcedelica
Contributor
Contributor

Hi - it doesn't appear that this change has made it to the sigar-1.6 or master branches.  Will it?  I have made the patch locally but I don't want it to get clobbered when I upgrade Sigar in the future.

Thanks,

0 Kudos