I tried to solve your problem and made the next new version of your script to make it run faster. It uses PowerCLI 4.1 features so you need that version to run this script. It uses pipelines instead of the foreach statement which is faster. And it uses the DatastoreBrowserPath property so you don't have use the New-PSDrive and Remove-PSDrive cmdlets. The output is delivered as an object which is more a PowerShell way of doing things than resulting strings.
Get-Datastore | ForEach-Object {
$Datastore = $_
Get-ChildItem $Datastore.DatastoreBrowserPath | `
Where-Object { $_.ItemType -eq "Folder" } | ForEach-Object {
$Folder = $_
Get-ChildItem "$($Datastore.DatastoreBrowserpath)\$($Folder.Name)" | `
Where-Object { $_.ItemType -eq "VmSnapshotFile" } | ForEach-Object {
$Report = "" | Select-Object -Property Datastore,Folder,SnapshotFile
$Report.Datastore = $Datastore.Name
$Report.Folder = $Folder.Name
$Report.SnapshotFile = $_.Name
$Report
}
}
}
The script is still very slow. Line 6, the second Get-ChildItem cmdlet causes the slowness.
I ran a timing test with the old and the new version and there was allmost no difference. The old version was even a few seconds faster. The results:
Old version 3 hours 59 minutes 21 seconds
New version 3 hours 59 minutes 53 seconds.
Sometimes you have to think out of the box to solve a problem. Yesterday I made a script in thread that uses plink.exe to call a console command from PowerCLI. In a console you can use the "find /vmfs/volumes -iname *.vmsn" command to get all the snapshot files in all datastore attached to the ESX server. So I adapted my script from yesterday to solve your problem. It runs much faster than the native PowerCLI script. Which I regret because I would like to be able to do everything in native PowerCLI. The script shows only snapshot files for datastores connected to ESX servers in clusters. It will not be difficult to change the script for standalone ESX servers. The script uses PowerShell v2 features.
$User = "root"
$Password = "password"
$Command = "find /vmfs/volumes -iname *.vmsn"
function Invoke-VMhostCommand {
# This function assumes that plink.exe is in your path
param([parameter(Mandatory=$true)][string] $VMHost,
[parameter(Mandatory=$true)][string] $User,
[parameter(Mandatory=$true)][string] $Password,
[parameter(Mandatory=$true)][string] $Command)
$plink = "plink.exe"
$plinkoptions = " -v -batch -pw $Password"
$remoteCommand = '"' + $Command + '"'
$PlinkCommand = $plink + " " + $plinkoptions + " " + $User + "@" + $VMHost + " " + $remoteCommand
$msg = Invoke-Expression -command $PlinkCommand
$Report = "" | Select-Object Host,Output
$Report.Host = $VMHost
$Report.Output = $msg
$Report
}
$Report = Get-Cluster | ForEach-Object {
Get-VMHost -Location $_ | Select-Object -First 1 | ForEach-Object {
Invoke-VMHostCommand -VMHost $_.Name -User $User -Password $Password -Command $Command
}
}
$Report | Select-Object -ExpandProperty Output
It will also be easy to change this script to return all the .vmx files, as Hal would like to do in the first post of this thread.
Timing test of this script against the same environment: 0 hours 0 minutes 53 seconds.
Regards, Robert
Message was edited by: RvdNieuwendijk
Blog: https://rvdnieuwendijk.com/ | Twitter: @rvdnieuwendijk | Author of: https://www.packtpub.com/virtualization-and-cloud/learning-powercli-second-edition
I'll try to stick to Sirry from now on.