We want to bundle 4 ESXi uplinks (vPC) and use LACP.
We want this uplink to be used for Management, vMotion, vSan and vm-data.
Are there any gotchas we have to consider?
I would personally recommend against that--not just using it for kernel services but also LACP in general. Reason being that LACP offers almost no benefit over a vDS with LBT. And since LACP requires use of a vDS anyway, you're just complicating your infrastructure unnecessarily. Additionally, by putting management vmkernel ports on an LACP bond, you open yourself up for ESXi outage issues if something goes wrong. So my recommendation is to not even use LACP at all with vSphere if you have a license to use a virtual distributed switch (vDS). Instead, simply use load-based teaming (LBT) on your virtual machine traffic only.
ESXi outage issues? Which kind of issues?
When the LAG goes down or has an issue and the ESXi host cannot be managed any more to restore connectivity.