Hi,
I'm using a script to automatically tag new VMs so they get backed up if the user which provisioned the VM forgot about it.
It works for a few months and then, I lose all my VM tags. It's already the second or third time that it occured, which is why I'm opening this thread (I don't really see why this is happening, as my script is only assigning a tag to untagged VMs).
I added the functions I'm using below because I don't understand why it works for so long then for no apparent reasons erase all my VM tags. The only event would be an ESX host that has been added in maintenance mode to the cluster. (but it should not bother the tags as they are managed by the vCenter, right ?)
Here is what my main function looks like (all the parameters are either inputs from the user, or from a configuration file if he forgets about it) :
Function Search-JenkinsUntaggedVMs
{
Param(
[string]$vCenter,
[Parameter(Mandatory = $true)]
$Destinataires,
[string]$TagName
)
#Connecting to the vCenter through a custom function (getting infos from a configuration file)
Connect-vCenter -vCenter $vCenter
#Getting the untagged VMs list through a custom function too)
$VMsUntagged = Get-UntaggedVMs
# it only does : $VMs = Get-VM | ?{ (Get-TagAssignment $_ -Category 'Backup') -eq $null} and returns $VMs
if($VMsUntagged)
{
#Getting the default tag from the configuration file
$configuration = Get-XMLConfig $($global:ScriptDir + "\Configuration.xml")
if([string]::IsNullOrEmpty($TagName))
{
$TagName = $configuration.VMware.DefaultTag
}
foreach($VM in $VMsUntagged)
{
#Then we tag each VM with the next function
Set-VMTag -VMName $VM.Name -TagName $JobName
}
}
else
{
$Message = 'blabla'
}
#Returning the newly tagged VMs list through email...
return Send-Email -Destinataires $Destinataires -Resultats $Message
}
And here is the function doing the VM tagging :
It uses 'try/catch' blocks because it's easier to check if it failed than to check if it already exists. (more 'pythonic' I guess)
Function Set-VMTag
{
Param(
[Parameter(Mandatory = $true)]
[string]$VMName,
[Parameter(Mandatory = $true)]
[string]$TagName
)
try
{
#Check that the category exists, if not I create it
$TagCategory = Get-TagCategory -Name "Backup"
if([string]::IsNullOrEmpty($TagCategory))
{
throw
}
}
catch
{
$TagCategory = New-TagCategory -Name "Backup"
}
try
{
#Check that the tag exists in this category, else I create it too
$Tag = Get-Tag -Name $TagName
if([string]::IsNullOrEmpty($Tag))
{
throw
}
}
catch
{
$Tag = New-Tag -Name $TagName -Category $TagCategory
}
try
{
#Then I tag my untagged VM
New-TagAssignment -Tag $Tag -Entity $(Get-VM -Name $VMName) | Out-Null
return $true
}
catch
{
return $false
}
}
If you see anything wrong with the way I'm doing it, or encountered this kind of problem before please share it 
.
Thanks
Accepted Solutions
