5 Replies Latest reply: Apr 17, 2007 4:17 PM by rmorgan_hyperic

HQ fails to monitor Tomcat when some JMX attributes contain dots ('.')

nickbr_hyperic (2 posts since Mar 18, 2007) Mar 18, 2007 9:24 PM

Currently Being Moderated

We have an application that exposes configuration properties as read-only JMX attributes, some of which contain dots -- path.to.something for example.

In this case, the response from /hyperic-hq/jmx-attributes?qry=* will look like:
...
Name: ...
path.to.something: ...
...

This, in turns, causes HQ agent to fail parsing the response:
2007-03-18 22:46:22,139 DEBUG [MeasurementCommandsServer] Error getting real tim
org.hyperic.hq.product.MetricInvalidException: Incorrect response from monitored
        at org.hyperic.hq.product.servlet.client.JMXRemote.refresh(JMXRemote.jav
        at org.hyperic.hq.product.servlet.client.JMXRemote.getRemoteInfo(JMXRemo
        at org.hyperic.hq.product.servlet.client.JMXRemote.getValue(JMXRemote.ja
        at org.hyperic.hq.product.servlet.client.JMXRemote.getRemoteMBeanValue(J
        at org.hyperic.hq.plugin.servlet.ServletMeasurementPlugin.getRemoteValue
        at org.hyperic.hq.plugin.servlet.ServletMeasurementPlugin.getValue(Servl
        at org.hyperic.hq.product.MeasurementPluginManager.getPluginValue(Measur
        at org.hyperic.hq.product.MeasurementPluginManager.getValue(MeasurementP
        at org.hyperic.hq.product.MeasurementPluginManager.getValue(MeasurementP
        at org.hyperic.hq.product.MeasurementPluginManager.getValue(MeasurementP
        at org.hyperic.hq.measurement.agent.server.MeasurementCommandsServer.get
        at org.hyperic.hq.measurement.agent.server.MeasurementCommandsServer.dis
        at org.hyperic.hq.agent.server.CommandDispatcher.processRequest(CommandD
        at org.hyperic.hq.agent.server.CommandListener.listenLoop(CommandListene
        at org.hyperic.hq.agent.server.AgentDaemon.start(AgentDaemon.java:680)
        at org.hyperic.hq.agent.server.AgentDaemon$RunnableAgent.run(AgentDaemon
        at org.hyperic.hq.agent.server.AgentDaemon.main(AgentDaemon.java:762)
Caused by: java.io.IOException: invalid header field name: path.to.something
        at java.util.jar.Attributes.read(Attributes.java:409)
        at java.util.jar.Manifest.read(Manifest.java:219)
        at java.util.jar.Manifest.<init>(Manifest.java:52)
        at org.hyperic.hq.product.servlet.client.JMXRemote.refresh(JMXRemote.jav
        ... 16 more

This is against HQ 3.0.2.

My proposed patch is:

*** JMXServlet.java.orig        2007-03-18 23:01:38.000000000 -0400
--- JMXServlet.java     2007-03-19 00:10:39.000000000 -0400
***************
*** 346,351 ****
--- 346,352 ----
                              Object o = mServer.getAttribute(oname, attName);
                              if(attName.indexOf( "=") >=0 ||
                                 attName.indexOf( ":") >=0 ||
+                                attName.indexOf( ".") >=0 ||
                                 attName.indexOf( " ") >=0 ) {
                                  continue;
                              }

1. Re: HQ fails to monitor Tomcat when some JMX attributes contain dots ('.')

noah_hyperic (70 posts since Oct 18, 2006) Mar 20, 2007 3:36 PM (in response to nickbr_hyperic)

Currently Being Moderated

Hi Nick,

Thanks for suggesting the code fix!

I'll take a look at the problem and also talk to the developers here about your patch.

--Noah--
Report Abuse

Like (0)
2. Re: HQ fails to monitor Tomcat when some JMX attributes contain dots ('.')

rmorgan_hyperic (424 posts since May 24, 2006) Mar 20, 2007 5:30 PM (in response to nickbr_hyperic)

Currently Being Moderated

Thanks the patch Nick. It's been applied to the tree and will be included in the next release.

The associated Jira ticket is http://jira.hyperic.com/browse/HHQ-757

As I'm sure you know, you'll need to re-instrument your Tomcat with the updated jmx-filter.jar.

-Ryan
Report Abuse

Like (0)
3. Re: HQ fails to monitor Tomcat when some JMX attributes contain dots ('.')

nickbr_hyperic (2 posts since Mar 18, 2007) Mar 21, 2007 5:52 AM (in response to rmorgan_hyperic)

Currently Being Moderated

Even though it is a simple fix I actually tried it before submiting it. I swear ;-)

I wonder if other characters wouldn't cause problems too, like # or $...
Report Abuse

Like (0)
4. Re: HQ fails to monitor Tomcat when some JMX attributes contain dots ('.')

hoverlover (1 posts since Apr 17, 2007) Apr 17, 2007 9:04 AM (in response to nickbr_hyperic)

Currently Being Moderated

I upgraded to version 3.0.3 yesterday and I still get the same error message as nickbr:

2007-04-17 10:59:25,151 ERROR [MeasurementCommandsServer] Error getting real time measurement: Invalid request: Incorrect response from monitored server

This message was from the agent log. I looked at the 3.0.3 source code and nickbr's fix is in there. Maybe there is another problem with my properties that the fix didn't take care of. All of my properties have dots in them, but no other characters other than alpha-numeric. The property values however do contain other characters. Please let me know how I can help fix this.
Report Abuse

Like (0)
5. Re: HQ fails to monitor Tomcat when some JMX attributes contain dots ('.')

rmorgan_hyperic (424 posts since May 24, 2006) Apr 17, 2007 4:17 PM (in response to hoverlover)

Currently Being Moderated

Did you make sure to replace the hq-filter.jar in your monitored application with the updated hq-filter.jar included in 3.0.3?

If so, can you:

1) Enable agent debug logging by editing agent.properties and changing the INFO line to DEBUG
2) Get the output of the jmx servlet

If you attach both to this thread we should be able to get you a fix.
Report Abuse

Like (0)

Go to original post

HQ fails to monitor Tomcat when some JMX attributes contain dots ('.')

1. Re: HQ fails to monitor Tomcat when some JMX attributes contain dots ('.')

2. Re: HQ fails to monitor Tomcat when some JMX attributes contain dots ('.')

3. Re: HQ fails to monitor Tomcat when some JMX attributes contain dots ('.')

4. Re: HQ fails to monitor Tomcat when some JMX attributes contain dots ('.')

5. Re: HQ fails to monitor Tomcat when some JMX attributes contain dots ('.')

More Like This

Share This Page