It's funny that you say that because the impression I got is that you kinda resented that I posted an alternate solution to the problem.
I think its quite cool that you posted your script online, and that you've been actively maintaining it, and I've given you credit for that since my first post.
There are two reasons why I started from scratch on this problem after trying your much earlier script in the lab.
First, you used python which was not supported by any of our resources in-house. We decided to leverage bash, gawk/awk, sed - tools that were very supportable and consistent with the rest of the deployment script suite we were developing. Your original version was not working correctly in our environment and we couldn't debug it, so we figured the problem out on our own and wrote our own script.
Also, you ignored the modules.conf file which is necessary to complete the nic renumeration properly. Otherwise you are going to have a port assignment mismatch in linux boot mode and lose connectivity. Further, you would leave the system inconsistent with the way it is intended to be deployed by VMware and when you do a support call and run into that problem, support will poo-poo the script.
Since I am a VCP and my primary mandate is to make things as conform to standards of practice as possible, I could not leave out the modules.conf fix from my script suite. If you look at the code I shared here, you'll see that the modules.conf fix is quite a bit more fancy that the esx.conf renumeration script. It had to be, to interpret the driver tables and pick the correct one.
The script was made by myself and another expert; combined we have over 30 years of Unix experience. We felt strongly that this was a required part of the solution and spent the extra time for good reason. The client (Federal Gov't) agreed. We wanted a reliable fix, not a partial hack.
An important note here is that
there is no reason why you can't use my modules.conf fix script with your own python script. The two stand alone.
I don't have a website which I am driving traffic to with this thread. I published the scripts on the VMware community to help out my colleagues, not to compete with you. I think there is plenty of room for different solutions to this problem. In fact, I think that having a little "competition" of sorts has driven you to improve your script greatly which can only be a positive thing all around for those who choose to use it.
Cheers!
-Richard Dagenais, VCP